Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recategorize config classes #17945

Merged
merged 13 commits into from
Aug 31, 2024
Merged

Conversation

alibektas
Copy link
Member

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 22, 2024
@alibektas
Copy link
Member Author

This made most of the ratoml tests invalid, which I will correct in a future PR.

@bors
Copy link
Contributor

bors commented Aug 23, 2024

☔ The latest upstream changes (presumably #17912) made this pull request unmergeable. Please resolve the merge conflicts.

@Veykril Veykril mentioned this pull request Aug 28, 2024
5 tasks
@lnicola
Copy link
Member

lnicola commented Aug 28, 2024

Nit: this should say ~/.config/rust-analyzer/rust-analyzer.toml instead of ~/.config/rust-analyzer.toml (cf.).

@alibektas alibektas force-pushed the ratoml_categorization branch from f5ab519 to 987a934 Compare August 28, 2024 17:33
crates/rust-analyzer/src/handlers/notification.rs Outdated Show resolved Hide resolved
crates/rust-analyzer/src/config.rs Outdated Show resolved Hide resolved
@Veykril
Copy link
Member

Veykril commented Aug 29, 2024

@bors delegate+

@bors
Copy link
Contributor

bors commented Aug 29, 2024

✌️ @alibektas, you can now approve this pull request!

If @Veykril told you to "r=me" after making some further change, please make that change, then do @bors r=@Veykril

@alibektas
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Aug 31, 2024

📌 Commit b17f1ee has been approved by alibektas

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 31, 2024

⌛ Testing commit b17f1ee with merge 30c14ca...

@bors
Copy link
Contributor

bors commented Aug 31, 2024

☀️ Test successful - checks-actions
Approved by: alibektas
Pushing 30c14ca to master...

@bors bors merged commit 30c14ca into rust-lang:master Aug 31, 2024
11 checks passed
@alibektas alibektas deleted the ratoml_categorization branch August 31, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants