fix: Update notify to 8.0.0
#18933
Merged
fix: Update notify to 8.0.0
#18933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Thanks! The CI fails because of this license check. But I think we should go directly to 8.0 if we're upgrading. |
|
Oh, did they change the license again in 8.0? |
lnicola
approved these changes
Jan 14, 2025
|
@decahedron1 just to be sure, did this fix your crash in #18932? |
|
Yep! (also, for that issue, I did have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18932 by updating the
notifycrate to v8.0, which fixed UB on Windows that resulted in aSTATUS_ILLEGAL_INSTRUCTIONin certain workspaces whenrust-analyzerwas compiled in release mode.