Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI a little bit safer #13933

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Make CI a little bit safer #13933

merged 1 commit into from
Jan 3, 2025

Conversation

blyxyas
Copy link
Member

@blyxyas blyxyas commented Jan 3, 2025

This PR fixes two vulnerabilities in our CI, found with zizmor. One could be exploited by someone with tag-pushing permissions to execute arbitrary code in our CI (seedeploy.yml). The second vulnerability would expose our tokens to a supply chain attack via a build.rs in one of the dependencies (See the rest of the files, and actions/checkout#485)

Pre-reviewed by @flip1995 in our DMs.

changelog:none

@rustbot
Copy link
Collaborator

rustbot commented Jan 3, 2025

r? @flip1995

rustbot has assigned @flip1995.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 3, 2025
@blyxyas blyxyas enabled auto-merge January 3, 2025 00:02
@blyxyas blyxyas added this pull request to the merge queue Jan 3, 2025
Merged via the queue into rust-lang:master with commit 7a01033 Jan 3, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants