Do not trigger redundant_pub_crate in external macros

[samueltardieu]

Some widely used crates, such as pin-project-lite, make use of a pub(crate) construct in a private module inside a public macro. This makes unrelated project trigger the lint.

There is also an unfortunate situation for Clippy itself: when a new version of pin-project-lite or similar lint-trigerring crates is released, those lints which can be found in hundreds of occurrences in dependent crates will change, and appear as diffs in unrelated Clippy PR because the base lintcheck run will be cached with the ancient release of the crates. We currently have the situation here, which 219 lints removed and 219 lints added because of a pin-project-lite version change between runs, and the fact that redundant_pub_crate triggers on external macros.

Also:

• Fix arithmetic_side_effects, redundant_pub_crate should not warn external macros #10636
• Fix Usage of tokio::select! triggers redundant_pub_crate (nursery) #12213

changelog: [redundant_pub_crate]: do not trigger on external macros

[rustbot]

r? @Centri3

rustbot has assigned @Centri3.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[samueltardieu]

Wow, 244 instances of the lint removed in the current PR lintcheck run. 🎆