Consider more erroneous layouts as LayoutError::ReferencesError to suppress spurious errors
#135264
+62
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ppress spurious errors
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
lukas-code
reviewed
Jan 8, 2025
| } | ||
| LayoutError::Unknown(ty) | ||
| } | ||
| LayoutCalculatorError::EmptyUnion => { | ||
| // This is always a compile error. |
There was a problem hiding this comment.
Can you do the same for the two delayed bugs below?
They are for these, which i suspect will still ICE:
union Foo {}
enum Bar {
Boo = {
let _: Option<Foo> = None;
0
},
}#[repr(u8, packed)]
enum Foo {
A
}
enum Bar {
Boo = {
let _: Option<Foo> = None;
0
},
}
|
sure thing 👍 |
bors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135208
r? oli-obk