Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --gcc-path option #608

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Add --gcc-path option #608

merged 2 commits into from
Jan 24, 2025

Conversation

GuillaumeGomez
Copy link
Member

No description provided.

antoyo
antoyo reviewed Jan 24, 2025
View reviewed changes
build_system/src/config.rs Outdated Show resolved Hide resolved
build_system/src/build.rs Outdated Show resolved Hide resolved
@GuillaumeGomez
Copy link
Member Author

Added comment and replaced unwrap calls with expect.

antoyo
antoyo reviewed Jan 24, 2025
View reviewed changes
build_system/src/config.rs Outdated Show resolved Hide resolved
build_system/src/config.rs Outdated Show resolved Hide resolved
@GuillaumeGomez
Copy link
Member Author

Fixed the unwrap I forgot and I added messages to know the GCC path used by the build script.

@GuillaumeGomez
Copy link
Member Author

Updated all expect messages.

@antoyo antoyo merged commit 5491581 into rust-lang:master Jan 24, 2025
31 checks passed
@antoyo
Copy link
Contributor

antoyo commented Jan 24, 2025

Thanks for your contribution!

@GuillaumeGomez GuillaumeGomez deleted the gcc-path branch January 24, 2025 20:34
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoyo antoyo antoyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeGomez @antoyo