Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding files exercise #521

Closed

Conversation

calvinbrown085
Copy link
Contributor

#482

This adds an example for reading in a file from the filesystem! Please let me know if I can do anything else here!

@calvinbrown085 calvinbrown085 changed the title Adding files exercise feat: Adding files exercise Sep 22, 2020
@AbdouSeck
Copy link
Contributor

Hi @calvinbrown085, thanks for proposing this feature. I am trying to figure out what the learner is supposed to do here. Are you trying to have the learner write the unit test case? If so, then the exercise won't work as written. The learner does not write and update unit tests. They update functions on top of the file, and your unit tests try to check the correctness of said functions.

For instance, in the file file1.rs, what probably want to have is an incomplete function definition at the top. So, this means leaving fn create_file() -> std::io::Result<()> {} incomplete. And then, you want to write unit tests that assert! that the file has been created.

Please feel free to reach out if you wish to discuss this further.

Thanks,
Abdou

@AbdouSeck AbdouSeck self-requested a review December 6, 2020 16:37
@AbdouSeck AbdouSeck self-assigned this Dec 12, 2020
@AbdouSeck AbdouSeck added the S-waiting-on-author Status: Waiting on issue/PR author label Dec 12, 2020
Copy link
Contributor

@AbdouSeck AbdouSeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please my comments above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: Waiting on issue/PR author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants