Expands the array! macro.
#1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the creation of arrays up to and including 6 dimensions, and causes a compiler error on 7 or more dimensions.
|
current status is that I'm trying to write up release notes for ndarray 0.16 so we get a release. It would be good to include this because it's technically a breaking change. (Type changes for identical source input). No stress though, just trying to explain the (supposed) plan. |
|
Sounds good - if there are any changes needed I can get to them fairly quickly. Also, I've been putting in PRs to help out and get familiar with the code base. If there's anything else I can do to help (write docs for the next release, run rustfmt on all the code, handle specific PRs you want in the next release, etc) please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the creation of arrays up to and including 6 dimensions, and causes a compiler error on 7 or more dimensions. Would close #1252.