rand_core: introduce an UnwrapMut wrapper #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
force-pushed
the
baloo/rand_core/unwrap_ref
branch
from
4f560d0 to
8bf3a29
Compare
dhardy
reviewed
Feb 15, 2025
This is used when a method takes in a `&mut impl TryRngCore` but the inner method requires an `&mut impl RngCore`. An `UnwrapErr` can not be used as it requires ownership of the rng.
baloo
force-pushed
the
baloo/rand_core/unwrap_ref
branch
from
8bf3a29 to
3de46b1
Compare
baloo
changed the title
|
Would you happen to know what the release schedule looks like? (And how long that will take to get patch release with this?) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
This is used when a method takes in a
&mut impl TryRngCorebut the inner method requires an&mut impl RngCore.An
UnwrapErrcan not be used as it requires ownership of the rng.Details