Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLVM+Clang][XTHeadVector] Implement intrinsics for vsmul #82

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

zhanyi22333
Copy link

  1. Rewrite vsmul's llvm part to be more in accordance with part in rvv.
  2. Imitate rvv clang part and YanWQ-monad to add test and defination.

Sorry for closing the previous PR. It seems not a good choice to close PR at will in github.

Copy link
Collaborator

@imkiva imkiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

Comment on lines 1105 to 1107
defm th_vsmul : RVVSignedBinBuiltinSetRoundingMode;
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bracket seems mistakenly indented.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified this mistake and rebased.

@ChunyuLiao ChunyuLiao merged commit 0861662 into ruyisdk:xtheadvector Mar 18, 2024
1 check passed
imkiva pushed a commit to imkiva/llvm-project that referenced this pull request Apr 1, 2024
* [LLVM][XTHeadVector] Change vsmul test cases

Make test more likely to rvv vsmul
Change intrinsic interface
Add csrwi vxrm sentence

* [LLVM][XTHeadVector] Redefine vsmul

* [Clang][XTHeadVector] Add test cases for vsmul

* [Clang][XTHeadVector] Define vsmul
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants