Invert calculation for the "Eights" in portrait mode #1541
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was configuring my screen that's on portrait mode with the Eights, the only one that fit my expectation was when it was on the Bottom Left corner of my screen. That's when I noticed on the code for Rectangle/WindowCalculation/BottomLeftEighthCalculation.swift the divisors are switched for the height and the width, while on the other calculations for the Eights are equal for both landscape and portrait mode.
This PR just switches them for the portrait mode for the other calculations.