Iteration 1-3 #12
Open
Iteration 1-3 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try 3.2 and 3.2.3
feat: integrate Bootstrap for UI enhancements
Chore: Set Up CI
This reverts commit 39ae894.
Chore: turned off action mailer
Add CodeClimate maintainability and test coverage badges to README.md…
[CHORE] Add PR Template
… are not used in the existing toy service and not needed in this branch
[FEAT!] Set Up Postgres For All Environments
[Chore] flextentions changed to flextensions. LGTM (@armandofox) after revisions so i'm forcing the merge.
[Add] Encrypt auth creds for access and refresh tokens
* Structure users controller
* Add documentation to swagger.json
* Delete white space
* Delete app/helpers/users_helper.rb
* Delete app/views/users/index.html.erb
* Pluralized "users" in "/courses/{course_id}/users/{users_id}"
* feat: structure put request for adding students to course
* Delete tests that are included in users_controller_spec.rb
The tests below are deleted
describe UsersController, type: :controller do
describe 'create' do
it "throws a 501 error" do
post :create
expect(response.status).to eq(501)
end
end
describe 'index' do
it "throws a 501 error" do
get :index
expect(response.status).to eq(501)
end
end
describe 'destroy' do
it "throws a 501 error" do
delete :destroy, params: { id: 1 }
expect(response.status).to eq(501)
end
end
end
* Remove this route from swagger.json temporarily: DELETE api/v1/courses/{course_id}/users/{user_id}
* Resolve bug in swagger
* Add delete route
* Fixed a typo
* Make the description of response more descriptive
* Make the description of responses more descriptive and fix typo
* Update users_controller.rb, make the message more descriptive
* Update courses_controller.rb, make the description more descriptive
* Update users_controller.rb, fix typo
---------
Co-authored-by: Connor Bernard <[email protected]>
Co-authored-by: Zzz212zzZ <[email protected]>
* feat: add validation helper * test: add test coverage for validation helper * chore: rename 'Errors' dir to 'errors'
* feat: add base class for facade * test: add test coverage for base extension facade * feat: create canvas facade * test: add test coverage for canvas facade * fix: flip inverted params * chore: remove 'CANVAS_URL' from ruby env * docs: document that 'CANVAS_URL' is necessary in environment
This reverts commit e6c7c8a.
* added space in schema for canvas data * Replace the external_course_id from courses table to course_to_lmss table --------- Co-authored-by: Zzz212zzZ <[email protected]>
187302440 fixing test badge
187434149 flow to create user
* Update Gemfile * Implemented create method; hasn't implemented frontend * Add course.rb in models * include ActionController::Flash * Modified create spec * Implemented index method * Add course_to_lms model * Clear index method * Modified create rspec * index method rendered a JSON * Cleared index * Modified create method * Modified create method * used create instead of new to add an entry to db * rspec test drafted * courses controller spec tests pass * courses controller spec tests pass * Delete useless `require lms_api` * Delete app/views/courses/index.html.erb --------- Co-authored-by: Sepehr Behmanesh Fard <[email protected]>
* make sure db can use environment vars * base seed data created * Models created with correct relations * test resources created for each model * seeded with new external data
* Implemented add_user in courses controller * Refactor code to eliminate repetitive code * Update user_to_course.rb
* Adjust Assignment Table, which should rely on course_to_lms instead of only lms * Add assignment model * Implement route of create in assignment controller * Add course, lms and course_to_lms model for Assignment Controller test * Add test for create in assignment controller * Refactor to pass the Codeclimate * Refactor the controller, by adding intger validation and putting ender from helper function to create function * Fix minor issue based on pr comments * Add one test to reach a full LOC test coverage * Add validation check for lms * Use validation helper * Update app/helpers/canvas_validation_helper.rb Co-authored-by: Connor <[email protected]> * Remove unecessary Rspec --------- Co-authored-by: Connor <[email protected]>
* Add models for course_to_lms * Implement creating association in course_to_lms * Test for creating association in course_to_lms * added space in schema for canvas data * Replace the external_course_id from courses table to course_to_lmss table * Take external_course_id into consideration * test coverage badge update * test coverage badge update 2 * code climate yml file updated * code climate yml file updated 2 * badge fix to linux * added codeclimate test reporter * added gems * simple cov version downgraded * simplecov v17 * secret added * secret added2 * secret added3 * secret added4 * initial changes to create user * drafted * validation email added * chnages added: new+save, has many asso for extension * Merge latest main into feature branch and resolve conflict * Refactor the controller and add integer validation * Fix potential issue in lmss_controller * Add validation check for lms * Use validation helper * Amend minor comments --------- Co-authored-by: Evan Kandell <[email protected]> Co-authored-by: Sepehr Behmanesh Fard <[email protected]>
* modified extensions_controller for extension setup flow * fixed extensions_controller_spec.rb * updated extensions_controller_spec.rb as per extensions_controller * fixed routes for extensions_controller_spec.rb * Add models for course_to_lms * Implement creating association in course_to_lms * Test for creating association in course_to_lms * correcting rspec for extensions controller * testing of api call completed * quick typo fix * added space in schema for canvas data * Replace the external_course_id from courses table to course_to_lmss table * More detailed extensions req, still needs more * Take external_course_id into consideration * I think set up correctly, needs rest of models to test * Adjust Assignment Table, which should rely on course_to_lms instead of only lms * Add assignment model * Implement route of create in assignment controller * Add course, lms and course_to_lms model for Assignment Controller test * Add test for create in assignment controller * Refactor to pass the Codeclimate * Refactor the controller, by adding intger validation and putting ender from helper function to create function * test coverage badge update * test coverage badge update 2 * code climate yml file updated * code climate yml file updated 2 * badge fix to linux * added codeclimate test reporter * added gems * simple cov version downgraded * simplecov v17 * secret added * secret added2 * secret added3 * secret added4 * initial changes to create user * drafted * validation email added * chnages added: new+save, has many asso for extension * Merge latest main into feature branch and resolve conflict * Refactor the controller and add integer validation * tests pass. finally. * improving test coverage * slightly clarified tests * remove render json of strings * Fix potential issue in lmss_controller * Fix minor issue based on pr comments * Add one test to reach a full LOC test coverage * starting to refactor * further refactoring * fixing everything that broke because someone decided to change the schema without telling anyone else... * everything works for demo * fixing failing tests due to prev updates * missed one merge * including validation helper * fixed comments as per PR46 (except line 30 of extensions_controller_spec, idk why it errors when I try to update those hashes to new syntax) * fix: ensure test succeed * style: format for readability --------- Co-authored-by: zee6197 <[email protected]> Co-authored-by: Zzz212zzZ <[email protected]> Co-authored-by: Sepehr Behmanesh Fard <[email protected]> Co-authored-by: Connor Bernard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the upstream iteration 1-3 pull request.
This PR is massive because this is a greenfield app so nearly all of this is boilerplate and config.