GH-1995 - Removed offset as we do the timezone handling in the client. #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…txdetail calls do not have a timezone offset
| ): Page<TxListEntry> | ||
|
|
||
| @GET("/v1/chains/{chainId}/safes/{address}/transactions/queued") | ||
| suspend fun loadTransactionsQueue( | ||
| @Path("chainId") chainId: BigInteger, | ||
| @Path("address") address: String, | ||
| @Query("timezone_offset") timezoneOffset: Int = TimeZone.getDefault().getOffset(Date().time) | ||
| @Query("timezone_offset") timezoneOffset: Int = 0 |
There was a problem hiding this comment.
Do we need this parameter at all then ?
There was a problem hiding this comment.
I wanted to leave it because it is in the api. And maybe someone wants to use it in the future. I just set the default to 0.
There was a problem hiding this comment.
Got referenced here from #3327. This change should bring inaccurate grouping of transactions by the date.
Since the client doesn't report the offset to the server, the transaction list can have some transactions appearing in the wrong day, if those transactions made closer to midnight.
the-real-chrizzo
approved these changes
Aug 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles #1995
Changes proposed in this pull request:
@gnosis/mobile-devs