Skip to content

Commit

Permalink
Address reviewer's comments
Browse files Browse the repository at this point in the history
  • Loading branch information
miguelmarco committed Oct 30, 2024
1 parent 72c12ac commit 66b81a0
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 16 deletions.
25 changes: 10 additions & 15 deletions src/sage/groups/braid.py
Original file line number Diff line number Diff line change
Expand Up @@ -2240,9 +2240,9 @@ def colored_jones_polynomial(self, N, variab=None, try_inverse=True):
self._cj_with_q[N] = cj.subs({q: 1/q}) if use_inverse else cj
return self.colored_jones_polynomial(N, variab, try_inverse)

def send_to_sss(self):
def super_summit_set_element(self):
r"""
Return an element of the braid's super summit set, an the conjugating
Return an element of the braid's super summit set and the conjugating
braid.
EXAMPLES::
Expand All @@ -2251,15 +2251,14 @@ def send_to_sss(self):
sage: b = B([1, 2, 1, 2, 3, -1, 2, 1, 3])
sage: b.send_to_sss()
(s0*s2*s0*s1*s2*s1*s0, s0^-1*s1^-1*s0^-1*s2^-1*s1^-1*s0^-1*s1*s0*s2*s1*s0)
"""
to_sss = send_to_sss(self)
B = self.parent()
return tuple(B._element_from_libbraiding(b) for b in to_sss)
return tuple([B._element_from_libbraiding(b) for b in to_sss])

def send_to_uss(self):
def ultra_summit_set_element(self):
r"""
Return an element of the braid's ultra summit set, an the conjugating
Return an element of the braid's ultra summit set and the conjugating
braid.
EXAMPLES::
Expand All @@ -2268,15 +2267,14 @@ def send_to_uss(self):
sage: b = B([1, 2, 1, 2, 3, -1, 2, -1, 3])
sage: b.send_to_uss()
(s0*s1*s0*s2*s1, s0^-1*s1^-1*s0^-1*s2^-1*s1^-1*s0^-1*s1*s2*s1^2*s0)
"""
to_uss = send_to_uss(self)
B = self.parent()
return tuple(B._element_from_libbraiding(b) for b in to_uss)
return tuple([B._element_from_libbraiding(b) for b in to_uss])

def send_to_sc(self):
def sliding_circuits_element(self):
r"""
Return an element of the braid's sliding circuits, an the conjugating
Return an element of the braid's sliding circuits, and the conjugating
braid.
EXAMPLES::
Expand All @@ -2285,11 +2283,10 @@ def send_to_sc(self):
sage: b = B([1, 2, 1, 2, 3, -1, 2, -1, 3])
sage: b.send_to_sc()
(s0*s1*s0*s2*s1, s0^2*s1*s2)
"""
to_sc = send_to_sc(self)
B = self.parent()
return tuple(B._element_from_libbraiding(b) for b in to_sc)
return tuple([B._element_from_libbraiding(b) for b in to_sc])

def trajectory(self):
r"""
Expand All @@ -2304,15 +2301,14 @@ def trajectory(self):
s0*s1*s2^3,
s0*s1*s2*s1^2,
s0*s1*s0*s2*s1]
"""
traj = trajectory(self)
B = self.parent()
return [B._element_from_libbraiding(b) for b in traj]

def cyclic_slidings(self):
r"""
Return the the braid's cyclic slidings.
Return the braid's cyclic slidings.
OUTPUT: The braid's cyclic slidings. Each cyclic sliding is a list of braids.
Expand All @@ -2323,7 +2319,6 @@ def cyclic_slidings(self):
sage: b.cyclic_slidings()
[[s0*s2*s1*s0*s1*s2, s0*s1*s2*s1*s0^2, s1*s0*s2^2*s1*s0],
[s0*s1*s2*s1^2*s0, s0*s1*s2*s1*s0*s2, s1*s0*s2*s0*s1*s2]]
"""
cs = cyclic_slidings(self)
B = self.parent()
Expand Down
2 changes: 1 addition & 1 deletion src/sage/libs/braiding.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ def cyclic_slidings(braid):
INPUT:
- ``braid```-- a braid
- ``braid`` -- a braid
OUTPUT:
Expand Down

0 comments on commit 66b81a0

Please sign in to comment.