working on L-function

src/sage/lfunctions/pari.py

@@ -270,11 +270,19 @@ def lfun_hecke(chi):
         sage: L = LFunction(lfun_hecke(chi))
         sage: L(3)
         ?
+
+        sage: F.<a> = NumberField(x^2 - 5)
+        sage: mf = F.modulus(F.ideal(4), [0, 1])
+        sage: H = HeckeCharacterGroup(mf)
+        sage: chi = H.gens()[1]
+        sage: L = LFunction(lfun_hecke(chi))
+        sage: [L(-n) for n in range(3)]
+        [1.00000000000000, 0.000000000000000, 15.0000000000000]
     """
     if not chi.is_primitive():
         chi = chi.primitive_character()
-    G, v = chi._pari_init_()
-    return pari.lfuncreate([G, v])
+    Gv = chi._pari_init_()
+    return pari.lfuncreate(Gv)
 
 
 def lfun_hgm(motif, t):

src/sage/modular/hecke_character.py

@@ -372,7 +372,7 @@ def dirichlet_series_coefficients(self, max_n):
             ans[n - 1] = sum(self(I) for I in Is)
         return ans
 
-    def Lfunction(self, prec=53):
+    def lfunction(self, prec=53):
         r"""
         Return this character's L-function.
 
@@ -395,46 +395,48 @@ def Lfunction(self, prec=53):
             sage: mf = F.modulus(F.ideal(4), [0, 1])
             sage: H = HeckeCharacterGroup(mf)
             sage: chi = H.gens()[1]
-            sage: L = chi.Lfunction(); L
+            sage: L = chi.lfunction(); L
             Hecke L-function of χ1
             sage: [L(-n) for n in range(3)]
             [1.00000000000000, 0.000000000000000, 15.0000000000000]
         """
         # Figure out Gamma factors for more general characters
-        gamma_factors = [0] * self.parent().number_field().degree()
-        for i in self.conductor().infinite_part():
-            gamma_factors[i] = 1
-        ana_cond = self.analytic_conductor()
-        rn = self.root_number()
+        # gamma_factors = [0] * self.parent().number_field().degree()
+        # for i in self.conductor().infinite_part():
+        #     gamma_factors[i] = 1
+        # ana_cond = self.analytic_conductor()
+        # rn = self.root_number()
 
         # OLD Dokchitser version, to be removed
         # Dokchitser(conductor, gammaV, weight, eps, poles, residues, init,
         # prec)
-        it_worked = False
-        number_of_allocs = 0
-        while not it_worked:
-            # Sage automatically ups the memory allocation, but this
-            # messes with L.num_coeffs for some reason I have yet to
-            # figure out, so L needs to be remade completely every
-            # time memory is auto-allocated. If we can control the
-            # auto-allocation process/rewrite the Dokchitser code,
-            # then we can remove the extra stuff here.
-            L = Dokchitser(ana_cond, gamma_factors, 1, rn, prec=prec)
-            for n in range(number_of_allocs):
-                L.gp().eval('allocatemem()')
-            try:
-                L.init_coeffs(self.dirichlet_series_coefficients(L.num_coeffs()))
-                it_worked = True
-            except RuntimeError:
-                number_of_allocs += 1
-
-        # NEW version, TODO: make correct lines below
-        lf = lfun_generic(conductor=ana_cond, gammaV=gamma_factors,
-                          weight=1, eps=rn)
-        # how to pick the correct number of coefficients ?
-        lf.init_coeffs(self.dirichlet_series_coefficients(L.num_coeffs()))
-
-        L = LFunction(lf, prec=prec)
+        # it_worked = False
+        # number_of_allocs = 0
+        # while not it_worked:
+        #     # Sage automatically ups the memory allocation, but this
+        #     # messes with L.num_coeffs for some reason I have yet to
+        #     # figure out, so L needs to be remade completely every
+        #     # time memory is auto-allocated. If we can control the
+        #     # auto-allocation process/rewrite the Dokchitser code,
+        #     # then we can remove the extra stuff here.
+        #     L = Dokchitser(ana_cond, gamma_factors, 1, rn, prec=prec)
+        #     for n in range(number_of_allocs):
+        #         L.gp().eval('allocatemem()')
+        #     try:
+        #         L.init_coeffs(self.dirichlet_series_coefficients(L.num_coeffs()))
+        #         it_worked = True
+        #     except RuntimeError:
+        #         number_of_allocs += 1
+
+        # # NEW version, TODO: make correct lines below
+        # lf = lfun_generic(conductor=ana_cond, gammaV=gamma_factors,
+        #                   weight=1, eps=rn)
+        # # how to pick the correct number of coefficients ?
+        # lf.init_coeffs(self.dirichlet_series_coefficients(L.num_coeffs()))
+
+        # instead use Pari directly:
+        from sage.lfunctions.pari import lfun_hecke
+        L = LFunction(lfun_hecke(self), prec=prec)
         L.rename(f'Hecke L-function of {self}')
         return L