remove the last use of PrincipalIdealDomain #38922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this class isn't used anymore, can the class itself be deleted entirely? It looks like it's already deprecated. |
|
Documentation preview for this PR (built with commit e798f08; changes) is ready! 🎉 |
|
I has only be deprecated formally recently. We have to wait one year after the first release after the deprecation. |
mantepse
reviewed
Nov 4, 2024
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 7, 2024
This is removing the last use of the auld class `PrincipalIdealDomain`
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
URL: sagemath#38922
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Martin Rubey
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 8, 2024
This is removing the last use of the auld class `PrincipalIdealDomain`
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
URL: sagemath#38922
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Martin Rubey
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 9, 2024
This is removing the last use of the auld class `PrincipalIdealDomain`
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
URL: sagemath#38922
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Martin Rubey
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 13, 2024
This is removing the last use of the auld class `PrincipalIdealDomain`
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
URL: sagemath#38922
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Martin Rubey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is removing the last use of the auld class
PrincipalIdealDomain📝 Checklist