Overwrote methods concerning loops for a matching covered graph #38955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoudert
suggested changes
Nov 10, 2024
Oh. |
|
Documentation preview for this PR (built with commit 91c97b4; changes) is ready! 🎉 |
|
Hi, |
|
Yes, it would be much better. I'm setting back this PR to needs review then. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 6, 2024
…overed graph
<!-- ^ Please provide a concise and informative title. -->
The objective of this issue is to overwrite the methods pertaining to
loops for a matching covered graph.
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
More specifically, this PR aims to implement/ update the following
methods:
- [x] `allow_loops()`: Change whether loops are allowed in (matching
covered) graphs.
- [x] `allows_loops()`: Return whether loops are permitted in (matching
covered) graphs.
- [x] `has_loops()`: Check whether thare are loops in the (matching
covered) graph.
- [x] `loop_edges()`: Return a list of all loops in the (matching
covered) graph.
- [x] `loop_vertices()`: Return a list of vertices with loops.
- [x] `loops()`: Return a list of all loops in the (matching covered)
graph.
- [x] `number_of_loops()`: Return the number of edges that are loops.
- [x] `remove_loops()`: Remove loops on vertices in ``vertices``.
<!-- v Why is this change required? What problem does it solve? -->
This PR shall address the methods related to loops for matching covered
graphs.
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Fixes sagemath#38216. Note that this issue fixes a small part of the mentioned
issue.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
This PR depends on the PR sagemath#38742.
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
cc: @dcoudert.
URL: sagemath#38955
Reported by: Janmenjaya Panda
Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 8, 2024
…overed graph
<!-- ^ Please provide a concise and informative title. -->
The objective of this issue is to overwrite the methods pertaining to
loops for a matching covered graph.
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
More specifically, this PR aims to implement/ update the following
methods:
- [x] `allow_loops()`: Change whether loops are allowed in (matching
covered) graphs.
- [x] `allows_loops()`: Return whether loops are permitted in (matching
covered) graphs.
- [x] `has_loops()`: Check whether thare are loops in the (matching
covered) graph.
- [x] `loop_edges()`: Return a list of all loops in the (matching
covered) graph.
- [x] `loop_vertices()`: Return a list of vertices with loops.
- [x] `loops()`: Return a list of all loops in the (matching covered)
graph.
- [x] `number_of_loops()`: Return the number of edges that are loops.
- [x] `remove_loops()`: Remove loops on vertices in ``vertices``.
<!-- v Why is this change required? What problem does it solve? -->
This PR shall address the methods related to loops for matching covered
graphs.
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Fixes sagemath#38216. Note that this issue fixes a small part of the mentioned
issue.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
This PR depends on the PR sagemath#38742.
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
cc: @dcoudert.
URL: sagemath#38955
Reported by: Janmenjaya Panda
Reviewer(s): David Coudert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective of this issue is to overwrite the methods pertaining to loops for a matching covered graph.
More specifically, this PR aims to implement/ update the following methods:
allow_loops(): Change whether loops are allowed in (matching covered) graphs.allows_loops(): Return whether loops are permitted in (matching covered) graphs.has_loops(): Check whether thare are loops in the (matching covered) graph.loop_edges(): Return a list of all loops in the (matching covered) graph.loop_vertices(): Return a list of vertices with loops.loops(): Return a list of all loops in the (matching covered) graph.number_of_loops(): Return the number of edges that are loops.remove_loops(): Remove loops on vertices invertices.This PR shall address the methods related to loops for matching covered graphs.
Fixes #38216. Note that this issue fixes a small part of the mentioned issue.
📝 Checklist
⌛ Dependencies
This PR depends on the PR #38742.
cc: @dcoudert.