Make tests compatible with numpy 2.1 #39242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit ba71bbd; changes) is ready! 🎉 |
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 7, 2025
As discussed in sagemath#39241 . Based on mkoeppe@6247975f786c85c35124a66a 0d32df00260461c5 , but also change the template file. Note that for tests to pass, sagemath#39242 is also needed. URL: sagemath#39291 Reported by: user202729 Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 9, 2025
As discussed in sagemath#39241 . Based on mkoeppe@6247975f786c85c35124a66a 0d32df00260461c5 , but also change the template file. Note that for tests to pass, sagemath#39242 is also needed. URL: sagemath#39291 Reported by: user202729 Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 10, 2025
As discussed in sagemath#39241 . Based on mkoeppe@6247975f786c85c35124a66a 0d32df00260461c5 , but also change the template file. Note that for tests to pass, sagemath#39242 is also needed. URL: sagemath#39291 Reported by: user202729 Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 12, 2025
As discussed in sagemath#39241 . Based on mkoeppe@6247975f786c85c35124a66a 0d32df00260461c5 , but also change the template file. Note that for tests to pass, sagemath#39242 is also needed. URL: sagemath#39291 Reported by: user202729 Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2025
As discussed in sagemath#39241 . Based on mkoeppe@6247975f786c85c35124a66a 0d32df00260461c5 , but also change the template file. Note that for tests to pass, sagemath#39242 is also needed. URL: sagemath#39291 Reported by: user202729 Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 17, 2025
As discussed in sagemath#39241 . Based on mkoeppe@6247975f786c85c35124a66a 0d32df00260461c5 , but also change the template file. Note that for tests to pass, sagemath#39242 is also needed. URL: sagemath#39291 Reported by: user202729 Reviewer(s): Tobias Diez
tobiasdiez
reviewed
Feb 5, 2025
tobiasdiez
approved these changes
Feb 6, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 9, 2025
Related to sagemath#38250 . In numpy 2.1 it returns a `Token` object which gets printed out. This assigns it to `_`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39242 Reported by: user202729 Reviewer(s): Tobias Diez, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 9, 2025
Related to sagemath#38250 . In numpy 2.1 it returns a `Token` object which gets printed out. This assigns it to `_`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39242 Reported by: user202729 Reviewer(s): Tobias Diez, user202729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #38250 .
In numpy 2.1 it returns a
Tokenobject which gets printed out. This assigns it to_.📝 Checklist
⌛ Dependencies