Witt vectors redone #39355
Witt vectors redone #39355
Conversation
The skeleton of the planned structure of Witt Vectors is implemented. There is essentially no functionality yet.
|
Documentation preview for this PR (built with commit 3d34b15; changes) is ready! 🎉 |
The term "Witt ring" refers to various objects Use "Witt vector ring" instead to remove any confusion
In the litterature, p-typical Witt vectors refer to this construction as oppososed to big Witt vectors Remove the wrong mentions in the code to reflect that Greatly simplifying it in the same time
Remove the 'auto' and 'none' keyword and handle None instead Add more liberty and exceptions in the general constructor
I had no clue what "otf" meant so I changed to a clearer algorithm name
We add documentation for every method, and also provide tests Thanks to the tests we discovered bugs which have been fixed The fix led to the use of __classcall_private__ instead of the previous constructor
|
@fchapoton C'est bon pour moi, si les tests passent. |
|
To everyone: I did a major cleanup of @nielrenned's code on Witt vectors during SageDays 128. My hope is to see this code finally merged into SageMath. I wonder though whether the function |
r-mb
added
s: needs review
sd128
This is based on the work from #11457, refreshed and cleaned up a little bit.
Still needs a lot of work on documentation and doctests : there are currently ZERO doctests.
📝 Checklist