Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use import_module instead of find_spec #39423

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Feb 1, 2025

Otherwise the test would fail with meson editable install. See https://github.com/sagemath/sage/actions/runs/13003203795/job/36265539648 .

Looks like the function was last changed in #36407. There was no discussion why the simple implementation is not used.

This is part of the fix for this test. The other part needed is #39498

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes. (can't really test, but see Test pip editable install with meson #39369)
  • I have updated the documentation and checked the documentation preview. (no documentation change)

⌛ Dependencies

Copy link

github-actions bot commented Feb 1, 2025

Documentation preview for this PR (built with commit ef72c43; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @tornaria is this change fine with you?

@tornaria
Copy link
Contributor

tornaria commented Feb 5, 2025

LGTM. @tornaria is this change fine with you?

I've no idea, this code is very old. I didn't write it, only fixed it to work on python 3.12.

The original code comes from from #15351 (comment). AFAICT, nothing uses this function load_submodules() so it should be irrelevant what you do about it, even remove it, but I don't know its purpose, maybe @videlec can comment.

I'm not using meson to build sagelib. For my void package I use the sagemath-standard sdist from pypi, which I don't think allows building with meson. Is there a published sdist to build sagelib with meson?

@tobiasdiez
Copy link
Contributor

@tornaria Thanks for the feedback. Tests are green (apart from the usual random failures), so let's get this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants