Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magma padics #39449

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Magma padics #39449

wants to merge 9 commits into from

Conversation

fchapoton
Copy link
Contributor

add back and forth conversion of simple padic Rings beween magma and sage.

This is only for parents, not for elements.

The correspondance of implementations is not clear. Does magma use relative or absolute capped precision ?

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025 •
edited
Loading

Documentation preview for this PR (built with commit 7ada96b; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fchapoton fchapoton requested a review from xcaruso February 10, 2025 15:44
xcaruso
xcaruso reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@xcaruso xcaruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can also set up a method _magma_init for capped absolute rings. I'm not sure.

src/sage/ext_data/magma/sage/basic.m Outdated Show resolved Hide resolved
src/sage/ext_data/magma/sage/basic.m Outdated Show resolved Hide resolved
@fchapoton
Copy link
Contributor Author

reading the doc there, it is still not very clear what is the exact correspondence between p-adic rings in magma and ours..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xcaruso xcaruso xcaruso left review comments

Assignees
No one assigned
Labels
c: interfaces: optional s: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fchapoton @xcaruso