Fixes error causing period function in BinaryRecurrenceSequence to stall and added enhancement #39546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 18, 2025 20:32
…rely periodic sequences.
…. Can now compute the period of sequences that are not purely periodic.
|
Documentation preview for this PR (built with commit 2b76379; changes) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38112. Fixed issue causing period function in BinaryRecurrenceSequence to stall. In the loop to calculate the period for the prime powers it now raises an error if you loop too many times. Added an enhancement to calculate the period of a not purely period BinaryRecurrenceSequence. To do this it basically just ignores the first m^2 terms and then calculates the period as normal.
📝 Checklist
⌛ Dependencies