-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement proper sandboxing (SailJail) configuration #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally developed by @poetaster and reviewed by @dcaliste in PR #75, see commits 68dc7f1 and fce86cd.
Olf0
changed the title
Implement a proper sandboxing (SailJail) configuration
Implement proper sandboxing (SailJail) configuration
Mar 12, 2024
dcaliste
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Olf0 for the separated PR. And thanks also @poetaster for the implementation and the explanations, I was also a bit slow to get the consequences of sandboxing…
Olf0
added a commit
that referenced
this pull request
Apr 12, 2024
* Post release version increase to 0.3.5 (#85) * [flowplayer.spec] Post release version increase * [flowplayer.changes] Add stub for v0.3.5 * Update README.md * Translate translations/flowplayer.ts in et (#86) 100% translated source file: 'translations/flowplayer.ts' on 'et'. Co-authored-by: Priit Jõerüüt (tlend) via transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> * [README.md] Add a feature * [README.md] Use better link * [README.md] Minimalistic wording improvement * Update README.md * Fixing a grammar error in FullAlbumSearch.qml (#88) Fixing a grammar error "there's no missing covers..." -> "there are no missing covers..." * Update utils.cpp (#87) Fixing a grammar error in several instances: "founded" -> "found" * Implement proper sandboxing (SailJail) configuration (#77) * [flowplayer.desktop] Implement a proper SailJail configuration Originally developed by @poetaster and reviewed by @dcaliste in PR #75, see commits 68dc7f1 and fce86cd. * [FlowPlayer.cpp] Eliminate migration functions due to conflict with sandboxing * [rpm/flowplayer.changes] Update for v0.3.5 * [CoverPage.qml] Fix string and run `lupdate` --------- Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> Co-authored-by: tuplasuhveli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally developed by @poetaster and reviewed by @dcaliste in PR #75, see commits 68dc7f1 and fce86cd.