Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement proper sandboxing (SailJail) configuration #77

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Conversation

Olf0
Copy link
Contributor

@Olf0 Olf0 commented Mar 11, 2024

Originally developed by @poetaster and reviewed by @dcaliste in PR #75, see commits 68dc7f1 and fce86cd.

Originally developed by @poetaster and reviewed by @dcaliste in PR #75, see commits 68dc7f1 and fce86cd.
@Olf0 Olf0 added the enhancement New feature or request label Mar 11, 2024
@Olf0 Olf0 self-assigned this Mar 11, 2024
@Olf0 Olf0 requested a review from dcaliste March 11, 2024 21:07
@Olf0 Olf0 marked this pull request as ready for review March 11, 2024 21:11
@Olf0 Olf0 changed the title Implement a proper sandboxing (SailJail) configuration Implement proper sandboxing (SailJail) configuration Mar 12, 2024
@dcaliste dcaliste requested review from dcaliste and removed request for dcaliste March 12, 2024 08:12
Copy link
Collaborator

@dcaliste dcaliste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Olf0 for the separated PR. And thanks also @poetaster for the implementation and the explanations, I was also a bit slow to get the consequences of sandboxing…

@Olf0
Copy link
Contributor Author

Olf0 commented Mar 12, 2024

Reminder to self

After PR #75 has been squash-merged into the devel branch, rebase this PR (#77, branch enable-sandboxing) on devel and kindly ask poetaster / dcaliste to run an lupdate on the checked out source tree of the enable-sandboxing branch.

@Olf0 Olf0 merged commit b8623db into devel Apr 11, 2024
1 check passed
@Olf0 Olf0 deleted the enable-sandboxing branch April 11, 2024 19:07
Olf0 added a commit that referenced this pull request Apr 12, 2024
* Post release version increase to 0.3.5 (#85)

* [flowplayer.spec] Post release version increase

* [flowplayer.changes] Add stub for v0.3.5

* Update README.md

* Translate translations/flowplayer.ts in et (#86)
  100% translated source file: 'translations/flowplayer.ts'
on 'et'.
  Co-authored-by: Priit Jõerüüt (tlend) via transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>

* [README.md] Add a feature

* [README.md] Use better link

* [README.md] Minimalistic wording improvement

* Update README.md

* Fixing a grammar error in FullAlbumSearch.qml (#88)
  Fixing a grammar error  "there's no missing covers..." -> "there are no missing covers..."

* Update utils.cpp (#87)
  Fixing a grammar error in several instances: "founded" -> "found"

* Implement proper sandboxing (SailJail) configuration (#77)

* [flowplayer.desktop] Implement a proper SailJail configuration
  Originally developed by @poetaster and reviewed by @dcaliste in PR #75, see commits 68dc7f1 and fce86cd.

* [FlowPlayer.cpp] Eliminate migration functions due to conflict with sandboxing

* [rpm/flowplayer.changes] Update for v0.3.5

* [CoverPage.qml] Fix string and run `lupdate`

---------

Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>
Co-authored-by: tuplasuhveli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants