Skip to content

Commit

Permalink
[patchmanager.cpp] Fix-up release 3.2.10 ⇒ 3.2.11 (#451)
Browse files Browse the repository at this point in the history
* [patchmanager.cpp] Fix-up release 3.2.10
  This was introduced by e30292b#diff-df38830cae3d3051528c63a2740fe3b0b4ec2c6b59aadab35dce5a1b6e995dd4R1016-R1035
  - Fix syntax / copy&paste error in second stub method.
  - Ultimately remove both empty/stub methods.

* [patchmanager.h] Slightly clarify comment

* [patchmanager.spec] Pre-release version increase

---------

Co-authored-by: nephros <nemo@pgxperiiia10>
  • Loading branch information
Olf0 and nephros authored Aug 15, 2023
1 parent d3e5ee2 commit 1fb70db
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 18 deletions.
2 changes: 1 addition & 1 deletion rpm/patchmanager.spec
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
Name: patchmanager

Summary: Allows to manage Patches for SailfishOS
Version: 3.2.10
Version: 3.2.11
Release: 1
# The Group tag should comprise one of the groups listed here:
# https://github.com/mer-tools/spectacle/blob/master/data/GROUPS
Expand Down
16 changes: 0 additions & 16 deletions src/qml/patchmanager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1013,22 +1013,6 @@ bool PatchManagerTranslator::installTranslator(const QString &patch)
return true;
}

/*! void PatchManager::activation(const QString & patch, const QString & version);
\warning probably dead code, need to investigate
probably \internal, using \a patch and \a version
*/
void PatchManager::activation(const QString & patch, const QString & version)
{
}

/*! void PatchManager::easterReceived(const QString & easterText);
\warning probably dead code, need to investigate
probably \internal, using \a easterText
*/
void PatchManager::easterReceived(const QString & easterText);
{
}

/*!
Returns \e true if \a filename exists, \e false otherwise.
\sa https://doc.qt.io/qt-5/qfile.html#exists-1
Expand Down
2 changes: 1 addition & 1 deletion src/qml/patchmanager.h
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class PatchManagerVersionCheck
enum CheckMode {
Strict,
NoCheck,
//Relaxed, // TODO, Issue #322, also see https://github.com/sailfishos-patches/patchmanager/issues/333#issuecomment-1374118045
//Relaxed, // TODO, see issue #322, also see https://github.com/sailfishos-patches/patchmanager/issues/333#issuecomment-1374118045
};
Q_ENUM(CheckMode)
private:
Expand Down

0 comments on commit 1fb70db

Please sign in to comment.