Gallery: zoom small images beyond display resoulution #10
Conversation
| - maximumWidth: model.width | ||
| - maximumHeight: model.height | ||
| + maximumWidth: model.width * 10 | ||
| + maximumHeight: model.height * 10 |
There was a problem hiding this comment.
it doesn't look good for me. better replace it with Math.max(model.width, view.width)
There was a problem hiding this comment.
Am 30.09.14 12:51, schrieb CODeRUS:
it doesn't look good for me. better replace it with
Math.max(model.width, view.width)
Ok, I did.
I wrote:
maximumWidth: Math.max(model.width, view.width)
maximumHeight: Math.max(model.height, view.height)
but I don't like the result.
Below is a link to my owncloud, showing a video with all 3 variants:
- original style
- my patch with * 10
- your suggestion (if I understand it right)
You will notice that variant 3 creates an unwanted rescaling which does
not respect the aspect ratio.
Besides I want to zoom really a lot.
And my patch is quite ugly, but it works and has only one minor
side-effect: you can not zoom out to original resolution, that means if
image is smaller than screen you can not view it at
1 pixel image = 1 pixel on screen.
Darvari
OK, this is my first time working with github (other than doing "git clone http...") I never did fork a project.
I wrote a patch for the gallery to enable more zooming - please also see here:
https://together.jolla.com/question/4416/gallery-zoom-beyond-display-resolution/#56483
Is this the right place and way to do it ? I mean forking sailfishos-patches-advanced and pull-request?
Greetings
Darvari