Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-49456 Lessons upgrade pdf-js from 2.9.359 to 4.0.189 #12096

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

mpellicer
Copy link

@mpellicer mpellicer commented Nov 16, 2023

Fixed.

image

@mpellicer mpellicer marked this pull request as draft November 16, 2023 12:51
@mpellicer mpellicer marked this pull request as ready for review November 16, 2023 14:05
Copy link
Contributor

@ern ern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpellicer You will also need to adjust the webjar version as well in library and I also saw sakai-document-viewer.js using this library so it needs to be updated as well.

@ern ern changed the title SAK-49456 Lessons: Upgrade pdf-js from 2.9.359 to 4.0.189 SAK-49456 Lessons upgrade pdf-js from 2.9.359 to 4.0.189 Nov 16, 2023
@mpellicer
Copy link
Author

@mpellicer You will also need to adjust the webjar version as well in library and I also saw sakai-document-viewer.js using this library so it needs to be updated as well.

It was done in #12081

@mpellicer mpellicer merged commit 90823d1 into sakaiproject:master Nov 28, 2023
@mpellicer mpellicer deleted the SAK-49456 branch November 28, 2023 11:00
ern pushed a commit that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants