SAK-49493 GB for groups: changes in Lessons, Forums, info blocks and more #13063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jumarub <[email protected]> Co-authored-by: JuanDavid102 <[email protected]>
jesusmmp
reviewed
Nov 27, 2024
| alerts.addAll(integrateGradebook(options, gradebookUid, aReference, item, null, null, null, -1, null, sReference, op, -1)); | ||
| } | ||
| } catch (NumberFormatException e) { | ||
| System.out.println("e: " + e); |
There was a problem hiding this comment.
Change to log.error or another log
bgarciaentornos
force-pushed
the
SAK-49493-nov
branch
from
bd0386c to
5b9504c
Compare
bgarciaentornos
commented
Dec 11, 2024
| // remove from Gradebook | ||
| List<String> gradebookUids = gradingService.getGradebookUidByExternalId(item); | ||
| for (String gradebookUid : gradebookUids) { | ||
| //TODO validar si ese guid va con grupo o da igual? |
There was a problem hiding this comment.
Suggested change
| //TODO validar si ese guid va con grupo o da igual? | |
| //TODO validar si ese guid va con grupo o da igual? |
bgarciaentornos
force-pushed
the
SAK-49493-nov
branch
from
5b9504c to
c84a32f
Compare
…config . . November changes in Lessons, Forums, info blocks and more
bgarciaentornos
force-pushed
the
SAK-49493-nov
branch
from
c84a32f to
b32f967
Compare
ern
force-pushed
the
SAK-49493
branch
2 times, most recently
from
51a050c to
ad5c4c3
Compare
ern
force-pushed
the
SAK-49493
branch
2 times, most recently
from
3447b0b to
db74c16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few pending changes, we'll update it soon