Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-50802 Lessons creates a Lessons links on navigation when there are no items in an export #13223

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

kunaljaykam
Copy link
Member

Archive shouldn't not import lessons with zero content

@kunaljaykam kunaljaykam requested a review from csev January 22, 2025 12:21
@kunaljaykam kunaljaykam marked this pull request as ready for review January 23, 2025 08:37
Copy link
Contributor

@csev csev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - I tested the branch.

@csev csev changed the title SAK-50802 Lessons multiple imports create duplicate Lessons links on navigation SAK-50802 Lessons creates a Lessons links on navigation when there are no items in an export Jan 23, 2025
@csev csev merged commit afd0c6b into sakaiproject:master Jan 23, 2025
5 checks passed
ern added a commit that referenced this pull request Jan 24, 2025
…there are no items in an export (#13223)"

This reverts commit afd0c6b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants