Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-50900 WC SakaiPermission sakai-group-picker change decorator to groups-selected #13226

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

ottenhoff
Copy link
Contributor

No description provided.

@ottenhoff ottenhoff requested a review from adrianfish January 22, 2025 20:25
@ottenhoff
Copy link
Contributor Author

ottenhoff commented Jan 22, 2025

Looking at both components, there's another potential issue. In SakaiPermissions.js, the _groupSelected handler expects a single value, but SakaiGroupPicker is sending an array of values (even when multiple is false).

@ern ern changed the title SAK-50900 WebComponents fix groups-selected SAK-50900 WC SakaiPermission fix groups-selected Jan 22, 2025
@ern ern changed the title SAK-50900 WC SakaiPermission fix groups-selected SAK-50900 WC SakaiPermission sakai-group-picker change decorator to groups-selected Jan 22, 2025
@ottenhoff ottenhoff requested a review from ern January 24, 2025 14:43
@ottenhoff ottenhoff merged commit 70e7708 into sakaiproject:master Jan 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants