SAK-50915 LTI send instructor role for DA user with instructor perms #13238
Conversation
|
@ottenhoff I don't understand. You are deleting a feature that was put there on purpose. Those role maps are there for tools with weird situations. We should just fix the role maps - they don't get in the way for the non-DA users. |
If you opened your code in an IDE, you would see some nice friendly suggestions that your role maps (in this specific method) are not doing a thing. You pass the role maps into this helper method and then you don't use them. |
| Map<String, String> propRoleMap = convertOutboundRoleMapPropToMap( | ||
| ServerConfigurationService.getString(LTI_OUTBOUND_ROLE_MAP) | ||
| ); | ||
| Map<String, String> defaultRoleMap = convertOutboundRoleMapPropToMap(LTI_OUTBOUND_ROLE_MAP_DEFAULT); |
There was a problem hiding this comment.
you dont use these. this method seems to be about returning a Sakai role only.
| AuthzGroup realm = ComponentManager.get(AuthzGroupService.class).getAuthzGroup(realmId); | ||
| if (realm != null) { | ||
| role = realm.getUserRole(user.getId()); | ||
|
|
There was a problem hiding this comment.
Now I see what you are doing. White space though :)
|
Thanks -Always love to delete code that does nothing. I see what you added and like it. Noted some whitespace :) Approved. |
|
Yup @ottenhoff I need to learn an IDE. I just fear the setup and learning curve. |
|
I only used vim until Earle convinced me to use IntelliJ! It’s pretty good.
And yes my white space changes here were unnecessary and only confused
things. Would have been a lot more clear if I didn’t touch that null check
…On Sat, Jan 25, 2025 at 2:25 PM Charles Severance ***@***.***> wrote:
Yup @ottenhoff <https://github.com/ottenhoff> I need to learn an IDE. I
just fear the setup and learning curve.
—
Reply to this email directly, view it on GitHub
<#13238 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGF4CNEB5POEQHGPBTB5TD2MPQJNAVCNFSM6AAAAABV3N5E3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJUGA3TGNBXGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No description provided.