SAK-50853 Gradebook Webcomponents more messaging fixes #13253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianfish
requested changes
Jan 30, 2025
gradebookng/tool/src/java/org/sakaiproject/gradebookng/rest/GradebookNgEntityProvider.java
Outdated
Show resolved
Hide resolved
gradebookng/tool/src/java/org/sakaiproject/gradebookng/rest/GradebookNgEntityProvider.java
Outdated
Show resolved
Hide resolved
| <div class="fs-5 mb-2">${this._i18n.success}</div> | ||
| <p>${this.formatMessage(this._i18n.messages_sent_detail || "Successfully sent messages to {numSent} recipients.", { numSent: this.numSent })}</p> | ||
| <button type="button" class="btn btn-primary" @click=${this.reset}> | ||
| ${this._i18n.send_another || "Send Another Message"} |
There was a problem hiding this comment.
This fallback should not be necessary. render will never be called unless this._i18n is defined and if this._i18n is defined theb send_another should be defined. Anything else is really messed up and needs looking into.
...nts/tool/src/main/frontend/packages/sakai-submission-messager/src/SakaiSubmissionMessager.js
Outdated
Show resolved
Hide resolved
...nts/tool/src/main/frontend/packages/sakai-submission-messager/src/SakaiSubmissionMessager.js
Outdated
Show resolved
Hide resolved
...nts/tool/src/main/frontend/packages/sakai-submission-messager/src/SakaiSubmissionMessager.js
Outdated
Show resolved
Hide resolved
|
Let me push a commit onto your branch before you do anything else. I'll be slow as a I have a broken wrist |
adrianfish
force-pushed
the
SAK-50853-b
branch
from
cd3d003 to
d5e7875
Compare
Used state = true for all the internal state vars Removed some unnecessary member var assignments Removed formatMessage, tr does the job
|
@ottenhoff I'm sorry but I think I've mangled your branch a bit. I tried to do a good thing by rebasing onto master and it has produced some odd results. However, I have done some cleanup on the js class that i hope is helpful. |
…adebookNgEntityProvider.java Co-authored-by: Adrian Fish <[email protected]>
|
thanks for changes. branch looks ok. it works. |
|
ok @adrianfish are you okay with the changes here? it all seems to work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially focused on what happens after a successful message is sent. Need to reset context for a new message.