Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-50926 DateManager gradebook due date throws DateTimeParseException #13254

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

ern
Copy link
Contributor

@ern ern commented Jan 29, 2025

https://sakaiproject.atlassian.net/browse/SAK-50926

  • restructured project to use standard maven project
  • added unit tests to DateManagerService
  • cleaned up a lot of lint issues

https://sakaiproject.atlassian.net/browse/SAK-50926
restructured project to use standard maven rpoject
cleaned up a lot of lint issues
@jonespm jonespm changed the title SAK-50926 DateMnanger gradebook due date throws DateTimeParseException SAK-50926 DateManager gradebook due date throws DateTimeParseException Jan 30, 2025
Copy link
Contributor

@adrianfish adrianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. You could extend the test classes from kernel, but that ain't no blocker.

@Slf4j
@RunWith(SpringJUnit4ClassRunner.class)
@ContextConfiguration(classes = {DateManagerTestConfiguration.class})
public class DateManagerServiceTest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the SakaiTest from kernel. along with the SakaiTestConfiguration? Saves some boilerplate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, thx

Copy link
Contributor Author

@ern ern Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok so after looking at the kernel tests these tests don't need DB configuration.
We should probably add to the kernel tests non DB test configuration as well.

@adrianfish
Copy link
Contributor

I've approved this, but if you have to make significant changes to fix the build I can re review

@ern ern merged commit 428ba46 into sakaiproject:master Jan 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants