Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] Allow for secure-boot efivars directory having SecureBoot-xxx files, not directories with a data file #66958

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

dmurphy18
Copy link
Contributor

@dmurphy18 dmurphy18 commented Oct 10, 2024

What does this PR do?

Correctly reads SecureBoot files from an efivars directory, previously attempted to treat them as directories with data files, that is what is in the old secure boot vars directory

What issues does this PR fix or reference?

Fixes #66955

Previous Behavior

Would report efi-secure-boot grain as False, when it should have reported True

New Behavior

Now reports efi-secure-boot grain as True, when it is True

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@dmurphy18 dmurphy18 added this to the Sulfur v3006.10 milestone Oct 10, 2024
@dmurphy18 dmurphy18 requested a review from a team as a code owner October 10, 2024 20:58
@dmurphy18 dmurphy18 requested a review from dwoz October 10, 2024 21:41
@dmurphy18 dmurphy18 self-assigned this Oct 10, 2024
@dwoz dwoz merged commit 1b680c6 into saltstack:3006.x Oct 15, 2024
181 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants