dl/difference-by: Added differenceBy #426
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Added difference-by
Summary of changes
I will call out though that this predicate signature/implementation is different than the lodashjs implementation found here https://lodash.com/docs/4.17.15#differenceBy but is consistent with the lodashjs version of differenceWith https://lodash.com/docs/4.17.15#differenceWith
Given that the sander/lo package doesn't have a pattern of using With(...) and that the function name and predicate shape is consistent with the naming convention of other similarly named functions in this Repo... (e.g NoneBy(...) ContainsBy(...)) I think this is naming convention is the best path forward for consistency and backwards compatibility sake.
Related issues
#411
#289 - I think this variant of difference would be nice to have as well but it should be named something different (maybe DifferenceTo or DifferenceWith) since it is inconsistent with other similarly named functions (e.g. NoneBy(...) ContainsBy(...)) in this repo