-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build 17.6.0 timed out #3042
Comments
duplicate of #3036 and meaningless suggestion. The build time of gitlab itself is getting longer and longer, and will almost certainly reach 1 hour (the upper limit in the free plan). If we don't review the build process itself, we will just waste time running CI. |
Apologies, search didn't pick that up, since the specific version is not mentioned in the issue. Might I suggest a workaround then of building it in another environment and pushing to the dockerhub? |
I'm running a locally built version of 17.6.0, but if someone publishes it on dockerhub it will help people who can't build it themselves. |
Fair enough. In the meanwhile, if anybody needs this very image built to 17.6.0 up to 17.6.2 I forked it, built them and published on the dockerhub here. |
I'm working on a multistage Dockerfile. Using BuildKit (docker buildx build or DOCKER_BUILDKIT=1 docker build), which allows parallel execution of stages I could save around 5 minutes. |
@kkimurak Unfortunately, I don't have the option of giving you the role of maintainer. @sameersbn Do you see a possibility to either change the plan for the CI or take up kkimurak's offer. He has also maintained the project remarkably so far. |
@sachilles @kkimurak given that @sameersbn does not seem to be very active on github anymore (At least there have been no contributions in the last year) would moving the ci/cd + docker-image to a new namespace controlled by either of you be a feasible option? |
Just for curiosity’s sake: What are the requirements to build the image? Any insights? |
@tDo If necessary, we should do so. I would like to get permission from all maintainers (with respect) if possible, but if we can't contact them, there is nothing we can do. However, I am still just a contributor (the most active - at least in terms of commits - except for the maintainer) and do not have (nor will I have) any decision-making authority. So what I'm trying to say is that I'm asking for more human resources with administrative privileges that can respond to emergencies. |
@Thomas-Ganter I don't know what the actual requirements are, but I think it's less than 6GB. Hints for 6GB memory requirement: Hint 1 : rake task docker-gitlab/assets/build/install.sh Line 215 in 76dad78
Hint 2 : It invokes system command Hint 3 : node command Anyway, I usually do local builds on two different virtual machines (Ubuntu) with 8GB / 16GB RAM. I have run out of memory once before on an 8GB machine, but since then I have disabled most services, including the GUI, and do no other work during the build, and have not run out of memory. |
Thanks @kkimurak — Running the build on a dedicated 8 core / 60GB machine worked for the single-architecture build, the multi-arch build timed out after 2 hrs and 11GB consumed memory in the builder container. Bumped the pipeline timeout to 4hrs and trying again ... |
Running a remote build (buildx with kubernetes driver) with 4 CPU, 4 GB
memory worked (in 40 minutes)
Am 31.12.2024 um 11:02 schrieb Thomas Ganter:
…
@Thomas-Ganter <https://github.com/Thomas-Ganter> I don't know
what the actual requirements are, but I think it's less than 6GB.
Hints for 6GB memory requirement:
[…]
Thanks @kkimurak <https://github.com/kkimurak> — Running the build on
a dedicated 8 core / 60GB machine worked for the single-architecture
build, the multi-arch build timed out after 2 hrs and 11GB consumed
memory in the builder container. Bumped the pipeline timeout to 4hrs
and trying again ...
—
Reply to this email directly, view it on GitHub
<#3042 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVVFCFYVCKD7I4S3Y2WNHC32IJTT5AVCNFSM6AAAAABTK5PYLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRWGMYDKNRQGU>.
You are receiving this because you commented.Message ID:
***@***.***>
|
Hmmm … for me a build with a 4hrs timeout just aborted. Then, I also do not know how to properly parallelize multi-architecture builds. |
I've no experience with multi-platform builds, but I'm working on
multistage (parallelized build steps), which might help.
Am 01.01.2025 um 02:09 schrieb Thomas Ganter:
…
Running a remote build (buildx with kubernetes driver) with 4 CPU,
4 GB memory worked (in 40 minutes)
Hmmm … for me a build with a 4hrs timeout just aborted.
I now have bumped the timeout to 8hrs, let's see whether this helps.
Then, I also do not know how to properly parallelize
multi-architecture builds.
Maybe this is my incompetence being the main culprit in my build drama
... any hints welcome.
—
Reply to this email directly, view it on GitHub
<#3042 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVVFCF56TOJUJLSRVUHQUBT2IM523AVCNFSM6AAAAABTK5PYLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRWG44DIOJVGU>.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sounds interesting. |
Please see https://github.com/th-2021/docker-gitlab/ multistage branch. docker buildx build -o type=registry -f Dockerfile.multistage --build-arg MAX_OLD_SPACE=${MAX_OLD_SPACE} . -t gitlab:17.6.0.1' gitlab is coming up, but more testing is needed. |
Are there additional patches needed for arm? I can try it on my setup. |
@th-2021 See #2803 - you may be need to edit around golang installation : https://github.com/th-2021/docker-gitlab/blob/616e07f1dc73851c13ebd678c94984b234288fc8/Dockerfile.multistage#L103 |
These are the changes I had to make
My repo should be publicly reviewable — if not please ping me and I will remediate. Once I am sufficiently confident I will update my homelab install, and then let's see … 8^) But beware … resource demand for a build is higher than a single-platform build: Update 2025-01-03in the
Background: The |
I'm sure many here are watching this thread and thinking: Your collective efforts are very much appreciated!! I cannot help with the build process (beyond my pay grade), but if you guys would like some end-user testing when images are available (against existing known to be working non prod instance - aka version upgrade testing) I'm pretty sure I can dedicate some time to testing (only as/when you're ready / needing). |
Hi @fidoedidoe — if you want to test something, my repo should be public at https://gitlab.fami.ga/misc/docker-gitlab. AFAIK all the build logs are also public (correct me if I am wrong), so you should be able to convince yourself that I did not do some sneaky shenanigans. Or you can also clone and build yourself if you want 17.6.2 and it's fixes. |
You can find an image for testing the multistage build at https://hub.docker.com/th2021/docker-gitlab |
I got 404 for https://hub.docker.com/th2021/docker-gitlab |
@th-2021 - I also get the 404 for the provided docker image url, but this one seems to work: https://hub.docker.com/r/th2021/docker-gitlab (for viewing in a web browser), i'll download ( EDIT 1: Docker Image sizeMy first observation based on docker image pull, is it's a lot bigger. Can I ask - were the docker layers squashed before pushing the image to docker hub (perhaps that's a next step once the image has been validated)?
Edit 1.1 - Docker Image SquashedUsing docker-squash.sh (link), I'm not promoting its use - just using it to illustrate the difference on the original docker image when compared to when it's squashed, the image ("th2021/docker-gitlab:17.6.2-squashed") is reduced significantly (and much more aligned with the sameersbn docker image size, as shown above)
EDIT 2: Upgrade successful & Web UI Runningokay an upgrade from sameersbn/gitlab:17.5.1 -> th2021/docker-gitlab:17.6.2-d7225209 on face value has worked - I can log in to GitLab Web UI as admin (detail below pulled from web UI / admin interface). I'll start testing git functions and GitLab UI tomorrow and will add findings/feedback to this post
EDIT 3: New/changed Env VarsRunning
EDIT 4: Git actions (clone, commit, push)Basic clone, modify, commit & push is successful & all changes are correctly reflected in web UI too. |
The image should be th2021/docker-gitlabAm 09.01.2025 18:23 schrieb Gavin Fowler ***@***.***>:
I got 404 for https://hub.docker.com/th2021/docker-gitlab correction: https://hub.docker.com/r/th2021/docker-gitlab
@th-2021 - I also get the 404 for the provided docker image url
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
First, thank you for maintaining this project over the years! I've been using sameersbn/docker-gitlab for quite some time now and have been very happy with its flexibility and modularity. However, I recently started revisiting my deployment choices and noticed that the official GitLab Docker image has come a long way since I first chose this project. I’d like to ask the community and maintainers for some guidance: What are the key advantages of continuing to use sameersbn/docker-gitlab today? Does this project still offer unique benefits that make it a better choice for long-term deployments? I appreciate the hard work that has gone into this project and understand it has been a great solution for many users, myself included. I’d love to hear thoughts from the maintainers and community on how sameersbn/docker-gitlab fits into the current GitLab Docker landscape and whether sticking with this setup remains a good long-term strategy. |
The offiziellen image doesn't support relative url, e.g. /gitlab
Am 9. Januar 2025 19:18:23 MEZ schrieb suchwerk ***@***.***>:
…First, thank you for maintaining this project over the years! I've been using sameersbn/docker-gitlab for quite some time now and have been very happy with its flexibility and modularity. However, I recently started revisiting my deployment choices and noticed that the official GitLab Docker image has come a long way since I first chose this project. I’d like to ask the community and maintainers for some guidance:
What are the key advantages of continuing to use sameersbn/docker-gitlab today?
Does this project still offer unique benefits that make it a better choice for long-term deployments?
Are there scenarios where this setup outperforms the official GitLab image in terms of flexibility, resource usage, or integrations? For example, are there significant benefits in terms of updates, security, or feature parity that the official image provides?
I appreciate the hard work that has gone into this project and understand it has been a great solution for many users, myself included. I’d love to hear thoughts from the maintainers and community on how sameersbn/docker-gitlab fits into the current GitLab Docker landscape and whether sticking with this setup remains a good long-term strategy.
--
Reply to this email directly or view it on GitHub:
#3042 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
@fidoedidoe The image might be bigger because some caches and other intermediate files are not deleted. |
take a look at the effect `docker-squash.sh" has on the image size (see EDIT 1.1 in my expanded post above, link) |
@Thomas-Ganter I updated my multistage build to 17.7.2 and now arm64 doesn't build any longer: |
@th-2021 :: I do not quite understand the "ubuntu 22.04" thing ... 16.x already was on I found that purging the build caches and/ or recreating the builder image helps when things get strange. Happy to have a look, and/ or we can also move the conversation elsewhere as to not hijack this issue for our conversation. |
17.7 is based on jammy (22.04), not focal (20.04)Am 23.01.2025 07:54 schrieb Thomas Ganter ***@***.***>:
@Thomas-Ganter I updated my multistage build to 17.7.2 and now arm64 doesn't build any longer:
[…]
Any idea? 17.7 switched to ubuntu 22.04.
@th-2021 :: I do not quite understand the "ubuntu 22.04" thing ... 16.x already was on focal-20241011.
My multi-arch still builds for 17.7.x, but 17.8 currently fails (after the build, but in the cleanup to reduct image size step).
I found that purging the build caches and/ or recreating the builder image helps when things get strange.
Happy to have a look, and/ or we can also move the conversation elsewhere as to not hijack this issue for our conversation.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
CI build for 17.6.0 seems to have timed out and 17.6.0 is not available on
dockerhub
. Please run the task again.The text was updated successfully, but these errors were encountered: