-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Multistage for parallel build #3048
base: master
Are you sure you want to change the base?
Conversation
Ok, it's done to build. It takes about 55m in total (47m to build). First impression: Is it possible to separate multistage build and circleci config updates? Regarding the multistage build, there are a lot of changes, and another comment #3042 (comment) pointed out that the image size has increased, so I think it would be a good idea to take some time to investigate this. |
Ok. Build worked within the same time range ~48 min, I'll separate circleci into a new PR. |
Great! |
This PR moves the builds from install.sh into Dockerfile.multistage, allowing for parallel build execution (with docker buildkit).
This changes circleci configuration to use large modell (4 CPU, 15 GB memory). Also buildkit is enabled. This brings down build time to 48 min on circleci.
@sachilles and @kkimurak please review this.
The change is parallel to the existing files: Dockerfile.multistage and install2.sh are used.