-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation & cleaning & refactoring #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
samsamfire
commented
Jan 10, 2024
- Adding more documentation to package : go docs & .md files for a quick setup / tutorial
- Unexporting a lot of structures / variables that don't need to be exported. Way too much structures etc when reading doc.
- More debug prints
- Fixed bug in heartbeat consumer, was missing heartbeats
All canopen objects now use embedding of bus manager : less code
… was not updated properly ==> missed heartbeat Added a configurator for hb consumer Added some tests Unexport everything inside HBConsumer Added logs for accessing object 1016
Unexported SYNC variables
Streamer is now an unexported type as it should not directly be used or created by user
Some renaming & unexporting
… and AddNode to AddRemoteNode Added some documentation on RemoteNode and LocalNode types
Added newBaseNode
Changed default loop time of main node process to 10ms Renamed Socketcan to SocketCan (same as VirtualCan) Added sdoclient to BaseNode
- sdo server returns abortcode & state - removed unnecessary assignment in local node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.