-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change README to AsciiDoc #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong feeling about this. The downside is that it seems a little more complicated then markdown, and people won't be familiar with it out of the box. It looks like it has some nice features like auto table of contents creation. I don't feel strongly either way.
README.adoc
Outdated
|
||
== Status | ||
|
||
[options="header", cols=2, caption=""] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably put these as a single horizontal line or as part of the badge line. This table looks nice but takes up most of the vertical space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
= htsjdk-next-beta | ||
:toc: macro | ||
|
||
image:http://img.shields.io/badge/language-java-brightgreen.svg[Language, link=https://www.java.com] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we go with asciidoc we might want a footnote at the bottom with a link to an asciidoc quick reference guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add something like that in the contributors guidelines, that I am preparing in combination with #42 and this PR (preparing is too optimistic, I just have in mind what I will propose).
README.adoc
Outdated
.... | ||
./gradlew assemble | ||
.... | ||
* Windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can asciidoc generate support those interactive panes where you can have multiple tabs for different language examples? Something like the panes here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is not built-in support for this, and I doubt that even if so the GitHub renders it properly (e.g., jekyll for gh-pages does not support very useful plugins...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did put them in a table form similar to the build.
Sorry for the delay weighing in on this. I have to say, I'm sorry, but I'm against switching away from MarkDown. My brain is already annoyed at having to recall both MarkDown and RST syntax, and adding yet another "not-HTML" language just to get an automated TOC seems like a bad tradeoff. It also looks more complicated (to my eye) than MarkDown, but that might be lack of familiarity. |
@tfenne - I understand you, as I was also against AsciiDoc now that I am using it but I found that not only the built-in TOC is a nice feature. I propose it for several reasons:
If you are still not convinced by this, I can give up the README. But I think that we should definetely write in AsciiDoc the technical documentation and user manual on how to use the library (and also in a way that the documentation is compiled and every test snippet is run - I have a very cool idea about this). And I would really like to have technical documentation to define a proper architecture to be able to fullfill all the requirements from other projects (e.g., see #34 and #42 for a concrete proposal designed before the implementation). |
Closing; in person conversation with @lbergelson - we agree to stay with MarkDown. |
Proposal to change the README to AsciiDoc, as it supports out-of-the-box "Table of Contents", apart of a really nice markup syntax (more consistent than Markdown).
Also, I included some changes in the content.
It also includes changes from #24: