Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update install samtools #1735

Merged
merged 2 commits into from
Dec 17, 2024
Merged

update install samtools #1735

merged 2 commits into from
Dec 17, 2024

Conversation

lbergelson
Copy link
Member

@lbergelson lbergelson commented Dec 17, 2024

Description

Please explain the changes you made here.
Explain the motivation for making this change. What existing problem does the pull request solve?

Things to think about before submitting:

  • Make sure your changes compile and new tests pass locally.
  • Add new tests or update existing ones:
    • A bug fix should include a test that previously would have failed and passes now.
    • New features should come with new tests that exercise and validate the new functionality.
  • Extended the README / documentation, if necessary
  • Check your code style.
  • Write a clear commit title and message
    • The commit message should describe what changed and is targeted at htsjdk developers
    • Breaking changes should be mentioned in the commit message.

@lbergelson lbergelson marked this pull request as ready for review December 17, 2024 22:39
@lbergelson
Copy link
Member Author

@cmnbroad I think this fixes it, provided tests pass. It adds a few minutes of mucking around with apt-get upgrade, so maybe I should remove that. We might also want to move to samtools 1.21.0 but I don't want to move it out from under you.

Copy link
Collaborator

@cmnbroad cmnbroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, assuming tests pass. Thanks for fixing this @lbergelson.

@lbergelson lbergelson merged commit 68567fa into master Dec 17, 2024
4 checks passed
@lbergelson lbergelson deleted the lb_fix_bgzip branch December 17, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants