Skip to content

Commit

Permalink
update cran comments
Browse files Browse the repository at this point in the history
  • Loading branch information
samuel-marsh committed Nov 6, 2023
1 parent a751695 commit abd468a
Showing 1 changed file with 11 additions and 4 deletions.
15 changes: 11 additions & 4 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
## Minor Version Update
This is a hotfix minor update from v1.1.2 to v1.1.3. In this version I have:
This is a major version update to v2.0.0. In this version I have:

- Fixed parameter documentation in function help/manual that slipped through release (see News.md). I'm sorry this was missed in submission yesterday. Parameter input changed substantially in v1.1.2 and therefore accurate documentation is required with hotfix instead of waiting until next release.
- Added a number of new functions, added new function parameters, and fixed bugs (see News.md).
- Ensured compatibility with major version of Seurat package.
- Fixed in example code causing current CRAN check errors with current package version (v1.1.3).


## R CMD check results

0 errors | 0 warnings | 1 notes

### Test environments
- Run locally, R4.1.2, Platform: x86_64-apple-darwin17.0 (64-bit) with `devtools:check()`.
- Run locally, R4.3.1, Platform: x86_64-apple-darwin17.0 (64-bit) with `devtools:check()`.
- Also run via GitHub Actions via `usethis::use_github_action_check_standard`
- macos-latest (release), windows-latest (release), ubuntu-latest (devel), ubuntu-latest (release), ubuntu-latest (oldrel-1).

Expand All @@ -20,4 +22,9 @@ This is a hotfix minor update from v1.1.2 to v1.1.3. In this version I have:
use conditionally.
- I have worked to move/remove as many IMPORTS to SUGGESTS as possible. This package aims to simplify a number of different
visualizations/code tasks in scRNA-seq analysis and as such does have diverse array of dependencies. I will monitor
to ensure package functionality.
to ensure package functionality.
2. Suggests or Enhances not in mainstream repositories:
rliger
- I hope this issue to be fixed soon as the maintainers have assigned team member to fix issue
(https://github.com/welch-lab/liger/issues/293). However, in the interim this loss will not effect package global package
functionality. Those looking for rliger functionality can still easily download versions from CRAN archive and GitHub.

0 comments on commit abd468a

Please sign in to comment.