better naming

Signed-off-by: Santhosh Gandhe <[email protected]>
san81 · Jan 16, 2025 · 78de3aa · 78de3aa
1 parent 009eafe
commit 78de3aa
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 12 deletions.
diff --git a/...plugin/FailedToUpdateSecretException.java → ...edToUpdatePluginConfigValueException.java b/...plugin/FailedToUpdateSecretException.java → ...edToUpdatePluginConfigValueException.java
@@ -14,13 +14,13 @@
  *
  * @since 2.11
  */
-public class FailedToUpdateSecretException extends RuntimeException {
+public class FailedToUpdatePluginConfigValueException extends RuntimeException {
 
-    public FailedToUpdateSecretException(final String message) {
+    public FailedToUpdatePluginConfigValueException(final String message) {
         super(message);
     }
 
-    public FailedToUpdateSecretException(final String message, Throwable e) {
+    public FailedToUpdatePluginConfigValueException(final String message, Throwable e) {
         super(message, e);
     }
 }
diff --git a/...in/FailedToUpdateSecretExceptionTest.java → ...UpdatePluginConfigValueExceptionTest.java b/...in/FailedToUpdateSecretExceptionTest.java → ...UpdatePluginConfigValueExceptionTest.java
@@ -18,7 +18,7 @@
 import static org.hamcrest.CoreMatchers.equalTo;
 import static org.hamcrest.MatcherAssert.assertThat;
 
-public class FailedToUpdateSecretExceptionTest extends RuntimeException {
+public class FailedToUpdatePluginConfigValueExceptionTest extends RuntimeException {
     private String message;
 
     @BeforeEach
@@ -28,14 +28,14 @@ void setUp() {
 
     @Test
     void testGetMessage_should_return_correct_message() {
-        FailedToUpdateSecretException failedToUpdateSecretException = new FailedToUpdateSecretException(message);
+        FailedToUpdatePluginConfigValueException failedToUpdateSecretException = new FailedToUpdatePluginConfigValueException(message);
         assertThat(failedToUpdateSecretException.getMessage(), equalTo(message));
     }
 
     @Test
     void testGetMessage_should_return_correct_message_with_throwable() {
         RuntimeException cause = new RuntimeException("testException");
-        FailedToUpdateSecretException failedToUpdateSecretException = new FailedToUpdateSecretException(message, cause);
+        FailedToUpdatePluginConfigValueException failedToUpdateSecretException = new FailedToUpdatePluginConfigValueException(message, cause);
         assertThat(failedToUpdateSecretException.getMessage(), equalTo(message));
         assertThat(failedToUpdateSecretException.getCause(), equalTo(cause));
     }

diff --git a/...-plugin/src/main/java/org/opensearch/dataprepper/plugins/aws/AwsPluginConfigVariable.java b/...-plugin/src/main/java/org/opensearch/dataprepper/plugins/aws/AwsPluginConfigVariable.java
@@ -9,7 +9,7 @@
  */
 package org.opensearch.dataprepper.plugins.aws;
 
-import org.opensearch.dataprepper.model.plugin.FailedToUpdateSecretException;
+import org.opensearch.dataprepper.model.plugin.FailedToUpdatePluginConfigValueException;
 import org.opensearch.dataprepper.model.plugin.PluginConfigVariable;
 
 /**
@@ -41,7 +41,7 @@ public Object getValue() {
     @Override
     public void setValue(Object newValue, String secretVersionIdToSet) {
         if (!isUpdatable()) {
-            throw new FailedToUpdateSecretException(
+            throw new FailedToUpdatePluginConfigValueException(
                     String.format("Trying to update a secrets that is not updatable. SecretId: %s SecretKey: %s", this.secretId, this.secretKey));
         }
         this.secretsSupplier.updateValue(secretId, secretKey, newValue, secretVersionIdToSet);

diff --git a/...s/aws-plugin/src/main/java/org/opensearch/dataprepper/plugins/aws/AwsSecretsSupplier.java b/...s/aws-plugin/src/main/java/org/opensearch/dataprepper/plugins/aws/AwsSecretsSupplier.java
@@ -14,7 +14,7 @@
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.core.type.TypeReference;
 import com.fasterxml.jackson.databind.ObjectMapper;
-import org.opensearch.dataprepper.model.plugin.FailedToUpdateSecretException;
+import org.opensearch.dataprepper.model.plugin.FailedToUpdatePluginConfigValueException;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import software.amazon.awssdk.services.secretsmanager.SecretsManagerClient;
@@ -169,7 +169,7 @@ public String updateValue(String secretId, String keyToUpdate, Object newValue,
                     keyToUpdate, secretId, putSecretValueResponse.versionId());
             return putSecretValueResponse.versionId();
         } catch (Exception e) {
-            throw new FailedToUpdateSecretException(
+            throw new FailedToUpdatePluginConfigValueException(
                     String.format("Failed to update the secret: %s to put a new value for the key: %s",
                             awsSecretManagerConfiguration.getAwsSecretId(), keyToUpdate), e);
         }

diff --git a/...gin/src/test/java/org/opensearch/dataprepper/plugins/aws/AwsPluginConfigVariableTest.java b/...gin/src/test/java/org/opensearch/dataprepper/plugins/aws/AwsPluginConfigVariableTest.java
@@ -17,7 +17,7 @@
 import org.junit.jupiter.params.provider.ValueSource;
 import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
-import org.opensearch.dataprepper.model.plugin.FailedToUpdateSecretException;
+import org.opensearch.dataprepper.model.plugin.FailedToUpdatePluginConfigValueException;
 
 import java.util.UUID;
 
@@ -56,7 +56,7 @@ void testSetValueFailure_when_secret_is_not_updatable() {
                 secretId, secretKey,
                 secretValue, false
         );
-        assertThrows(FailedToUpdateSecretException.class, () -> objectUnderTest.setValue("new-secret-to-set", "randomSecretId"));
+        assertThrows(FailedToUpdatePluginConfigValueException.class, () -> objectUnderTest.setValue("new-secret-to-set", "randomSecretId"));
     }
 
     @ParameterizedTest