-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ap/unsubscribe after 3 notifs #218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made a suggestion, could be for a future ticket but i think it would be best addressed now so it doesn't get overlooked down the line.
@@ -37,6 +37,10 @@ jobs: | |||
node-version: "16" | |||
- uses: bahmutov/npm-install@v1 | |||
|
|||
- run: yarn db:migrate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this yaml change wasn't intended to be a fix, just a proof of concept. i think it would make sense if we broke down the test directories into unit and integration subdirectories, and had separate testing CI for unit vs integration tests. it's best if we have clear separation between unit and integration, just in case we have tests that were intended to be unit tests but ended up relying on some dependency. would also be best if the unit tests did not have the db, elastic, or graph spun up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that makes sense, I kept the general subdirectory to hold integration tests & have made a separate unit subdirectory.
Purpose
To reduce twilio costs, a user will be automatically unsubscribed from a course/section after they receive 3 text notifications for that course/section.
Tickets
https://trello.com/c/Aknz6Jdf
Contributors
@ananyaspatil @sebwittr @pranavphadke1 @elvincheng3
Feature List
Reviewers
Primary:
@sebwittr @pranavphadke1 @Anzhuo-W @Lucas-Dunker
Secondary reviewers:
@cherman23 @nickpfeiffer05 @mehallhm