Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added code for multiple BCs per sideset #42

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

eparish1
Copy link
Collaborator

Fixed a few things for op-inf when we have multiple BCs on a sideset and fixed a few things that I missed in the merge.

*I see that the unit tests are failing for all branches right now, so I'm not sure what we want to do for merges at this point.

@ikalash
Copy link
Collaborator

ikalash commented Jan 28, 2025

I think the failures are my fault! I will fix this. Sorry about this, I have been restructuring some of the tests.

@ikalash
Copy link
Collaborator

ikalash commented Jan 29, 2025

I just fixed the failing tests. My apologies again for breaking them!

@lxmota
Copy link
Collaborator

lxmota commented Jan 29, 2025

I don't think it's your fault. There is an issue on MacOS that flags a missing file in error that I'm trying to fix.

@ikalash
Copy link
Collaborator

ikalash commented Jan 29, 2025

I don't think it's your fault. There is an issue on MacOS that flags a missing file in error that I'm trying to fix.

Part of it was my fault. I rearranged some of the tests dirs when I added the input files for the new cylinder problem and forgot to update the tests .jl files accordingly.

I didn't run tests before pushing b/c I was not changing anything in the code, but forgot that the dir structure of the tests needs to be updated. That's how the bug got pushed.

@lxmota lxmota merged commit 87abe82 into main Jan 29, 2025
0 of 3 checks passed
@eparish1 eparish1 deleted the eparish1/opinf-add-sidesets branch January 30, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants