Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the beginning of the second stage of #1630. More particularly, it introduces a new module to Sanic internals:
sanic.touchup
.The idea with this module is that there will be predefined comment/markers that will modify executable functions at startup.
For example, the code to run request middleware looks like this:
At startup, there is a predefined interface that will lookup whether or not the
http.middleware.before
orhttp.middleware.after
signals have been implemented. If not, then nothing happens. If yes, then the touchup module will inject signal dispatchers in those locations.This should allow Sanic developers to make good use of signals to inject functionality, but not to slow down the req/resp cycle needlessly.
TODO: