Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support shopware6 version and base urls #26

Merged
merged 7 commits into from
Jan 10, 2025
Merged

support shopware6 version and base urls #26

merged 7 commits into from
Jan 10, 2025

Conversation

danslo
Copy link
Contributor

@danslo danslo commented Jan 10, 2025

  • Moved composer logic to separate file, so it can be reused for Shopware.
  • Removed support for determining versions by git clones (very rare, and complicates abstraction).
  • Deduplicate store roots in DiscoverStores, this was detecting 3 Shopware instances in /var/www/html. I suspect this might currently cause confusion in ecomscan interactive as well.
  • Implement sw6 Version and BaseURLs methods.

Result:

www-data@sw6prod-php-fpm:/var/www/html$ ./find 
Found 1 stores
Shopware 6 (ver: 6.6.9.0) at /var/www/html
DBC: &{Host:mysql User:app Pass:app Name:shopware Prefix: Port:3306}
Base URLs:
- http://127.0.0.1:8000

Previously:

Found 3 stores
Shopware 6 (ver: 6.6.9.0) at /var/www/html
DBC: &{Host:mysql User:app Pass:app Name:shopware Prefix: Port:3306}
Base URLs:
- http://127.0.0.1:8000

Shopware 6 (ver: 6.6.9.0) at /var/www/html
DBC: &{Host:mysql User:app Pass:app Name:shopware Prefix: Port:3306}
Base URLs:
- http://127.0.0.1:8000

Shopware 6 (ver: 6.6.9.0) at /var/www/html
DBC: &{Host:mysql User:app Pass:app Name:shopware Prefix: Port:3306}
Base URLs:
- http://127.0.0.1:8000

@danslo danslo requested a review from gwillem January 10, 2025 12:31
@danslo
Copy link
Contributor Author

danslo commented Jan 10, 2025

Checking tests :)

Copy link
Contributor

@gwillem gwillem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@danslo danslo merged commit 19a06cb into main Jan 10, 2025
3 checks passed
@danslo danslo deleted the sw6-base-url branch January 10, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants