sap_*: add noqa to sles python3-rpm

sap-linuxlab · May 6, 2024 · e9ea664 · e9ea664
1 parent e99de17
commit e9ea664
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/roles/sap_anydb_install_oracle/tasks/oracledb_install_pre.yml b/roles/sap_anydb_install_oracle/tasks/oracledb_install_pre.yml
@@ -1,7 +1,9 @@
 ---
 
+# Reasons for noqa:
+# - command-instead-of-module: Use command to install package required for Ansible Module package/package_facts
 - name: For SLES ensure OS Package for Python Lib of rpm bindings is enabled for System Python
-  ansible.builtin.command: zypper install --no-confirm --auto-agree-with-licenses python3-rpm
+  ansible.builtin.command: set -o pipefail && zypper install --no-confirm --auto-agree-with-licenses python3-rpm # noqa: command-instead-of-module
   when: ansible_os_family == "Suse"
 
 # See further:

diff --git a/roles/sap_general_preconfigure/tasks/main.yml b/roles/sap_general_preconfigure/tasks/main.yml
@@ -82,8 +82,10 @@
   tags:
     - always
 
+# Reasons for noqa:
+# - command-instead-of-module: Use command to install package required for Ansible Module package/package_facts
 - name: For SLES ensure OS Package for Python Lib of rpm bindings is enabled for System Python
-  ansible.builtin.command: zypper install --no-confirm --auto-agree-with-licenses python3-rpm
+  ansible.builtin.command: set -o pipefail && zypper install --no-confirm --auto-agree-with-licenses python3-rpm # noqa: command-instead-of-module
   when: ansible_os_family == "Suse"
 
 # required for installation and configuration tasks:

diff --git a/roles/sap_hana_preconfigure/tasks/main.yml b/roles/sap_hana_preconfigure/tasks/main.yml
@@ -27,8 +27,10 @@
     __sap_hana_preconfigure_fact_ansible_distribution_minor_version: '{{ ansible_distribution_version.split(".")[1] }}'
   when: ansible_distribution == 'RedHat'
 
+# Reasons for noqa:
+# - command-instead-of-module: Use command to install package required for Ansible Module package/package_facts
 - name: For SLES ensure OS Package for Python Lib of rpm bindings is enabled for System Python
-  ansible.builtin.command: zypper install --no-confirm --auto-agree-with-licenses python3-rpm
+  ansible.builtin.command: set -o pipefail && zypper install --no-confirm --auto-agree-with-licenses python3-rpm # noqa: command-instead-of-module
   when: ansible_os_family == "Suse"
 
 # required for installation and configuration tasks:

diff --git a/roles/sap_netweaver_preconfigure/tasks/main.yml b/roles/sap_netweaver_preconfigure/tasks/main.yml
@@ -22,8 +22,10 @@
     assert_prefix: "assert-"
   when: sap_netweaver_preconfigure_assert | d(false)
 
+# Reasons for noqa:
+# - command-instead-of-module: Use command to install package required for Ansible Module package/package_facts
 - name: For SLES ensure OS Package for Python Lib of rpm bindings is enabled for System Python
-  ansible.builtin.command: zypper install --no-confirm --auto-agree-with-licenses python3-rpm
+  ansible.builtin.command: set -o pipefail && zypper install --no-confirm --auto-agree-with-licenses python3-rpm # noqa: command-instead-of-module
   when: ansible_os_family == "Suse"
 
 # required for installation and configuration tasks: