Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_swpm: variable corrections #509

Merged
merged 8 commits into from
Nov 15, 2023

Conversation

sean-freeman
Copy link
Member

@sean-freeman sean-freeman commented Nov 4, 2023

sap_swpm: fix ibmdb2 unicode enforce

By default #NW_getUnicode.isUnicode = exists in inifile.params output, and defaults to true. In certain IBM Db2 executions, the automatic detection does not work and requires NW_getUnicode.isUnicode = true contained in the inifile.params. This value should already be true except for legacy NUC install files, which are no longer provided by SAP, therefore appending this into the default inifile block for IBM Db2 installations.

sap_swpm: improve var handling for advanced exec

When executing advanced or inifile reuse, variable detection can fail. Added improved handling and consistent output (i.e. header of inifile.params).

sap_swpm: improve vars for System Copy and Export activities

For future, appended System Copy and Export variables to Jinja template as reference, and fixed DDIC password parameter which was in the incorrect section and could lead to SAP ECC Installation Export file failure to import to the target SAP AnyDB.

sap_swpm: fix IBM Db2 incorrect var population

Database Schema and Database Connect User for ABAP is default sap<sapsid> but previous code incorrectly used sap<anydbsid>.

@berndfinger berndfinger self-requested a review November 10, 2023 17:25
@sean-freeman sean-freeman changed the title sap_swpm: ibmdb2 unicode enforce sap_swpm: variable corrections Nov 14, 2023
Copy link
Member

@berndfinger berndfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berndfinger berndfinger merged commit a233540 into sap-linuxlab:dev Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants