sap_install_media_detect: Leave non-role directories untouched #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the output of 'sapfile -s', we are able to get the names of directories into which the role moves SAP archive files. So the role can now move files from there back to the top level and remove those directories. The extracted directories are also (recursively) removed at this stage. The above is needed for idempotency (meaning that the role can run twice or more and the result is always identical). All other directories remain in place, including their contents. Solves issue sap-linuxlab#523.
berndfinger
changed the title
sean-freeman
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
lgtm 👍 this will permit an end-user to use a directory (e.g. /software_files) to store more than just the SAP software binaries (for example backup files and 3rd party addon software) without concern these additional files could be removed by the Ansible Role
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the beginning, we currently need to move files from lower level directories to the top level so that all SAP archive files are in the same directory and the role always starts file handling at the same status (future versions might support using also the desired file location in separate subdirectories).
We want the role to only move files from directories the role is able to create, and leave all other directories in place, including their contents. This is the purpose of this PR.
Solves issue #523 .