Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_hypervisor_node_preconfigure: Minor fixes #553

Merged
merged 8 commits into from
Jan 8, 2024
Merged

sap_hypervisor_node_preconfigure: Minor fixes #553

merged 8 commits into from
Jan 8, 2024

Conversation

newkit
Copy link
Contributor

@newkit newkit commented Dec 18, 2023

No description provided.

@berndfinger berndfinger changed the title Minor fixes sap_hypervisor_node_preconfigure: Minor fixes Dec 18, 2023
@berndfinger
Copy link
Member

LGTM.
@newkit: What was the reason for the double quotes around true in df5b586 (just for the records)?

@newkit
Copy link
Contributor Author

newkit commented Jan 8, 2024

@berndfinger Simply the fact that the double quotes are needed there in order to work.

@Wabri
Copy link
Member

Wabri commented Jan 8, 2024

@berndfinger it is the definition of a k8s configuration and in this case feature.node.kubernetes.io/network-sriov.capable takes a string and not a boolean.

You can find the documentation for this component in here https://docs.openshift.com/container-platform/4.9/networking/hardware_networks/about-sriov.html

And also a configuration example in here https://docs.openshift.com/container-platform/4.8/networking/hardware_networks/configuring-sriov-device.html#nw-sriov-networknodepolicy-object_configuring-sriov-device

@berndfinger
Copy link
Member

@Wabri Many thanks!

@berndfinger berndfinger merged commit cc9e20e into sap-linuxlab:dev Jan 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants