Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_hypervisor_node_preconfigure: Fix role name #626

Closed
wants to merge 2 commits into from

Conversation

newkit
Copy link
Contributor

@newkit newkit commented Jan 26, 2024

Added FQRN for role used in example playbook for sap_hypervisor_node_preconfigure.

@kksat
Copy link
Contributor

kksat commented Jan 26, 2024

@newkit I suppose you by mistake want to merge into main

Copy link
Contributor

@kksat kksat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

- name: Include Role
ansible.builtin.include_role:
name: sap_hypervisor_node_preconfigure
roles:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, thats actually what this PR should address. And yes, it was accidentally (auto suggested) created agains main, closing.

@sean-freeman sean-freeman changed the base branch from main to dev January 26, 2024 15:36
@newkit
Copy link
Contributor Author

newkit commented Jan 26, 2024

This should not have been created against main branch.

@newkit newkit closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants